SPONSORS:






User Tag List

Thanks Thanks:  0
Likes Likes:  0
Dislikes Dislikes:  0
Results 1 to 6 of 6
  1. #1
    Senior Member
    Join Date
    Sep 2003
    Posts
    114
    Post Thanks / Like
    Mentioned
    0 Post(s)
    Tagged
    0 Thread(s)
    Total Downloaded
    0

    Code Reviews Benefits

    Hi,

    I would like to refer you to a short article about the somewhat less obvious benefits of code reviews:

    http://www.qualityprogramming.org/Mi...onBenefits.htm

    Any comments are appreciated....

    Lidor
    Lidor Wyssocky
    http://www.QualityAspect.com

    Visit The Mindset - Lidor Wyssocky's blog on Optimizing Software Development
    http://blog.QualityAspect.com

  2. #2
    Senior Member
    Join Date
    Jan 2005
    Location
    Aurora, Ont., Canada
    Posts
    1,174
    Post Thanks / Like
    Mentioned
    0 Post(s)
    Tagged
    0 Thread(s)
    Total Downloaded
    0

    Re: Code Reviews Benefits

    Lidor,

    I understand where you come from, but there is a definite vacuum in what you are trying to focus on in this article:

    HOW --> Your focus is on how the software seems to be implemented. I fully agree with the points you make about improving the quality of the code, but it does not seem to address the major issue I see as critical to a code review, namely fitness for implementation based on requirements.

    WHAT --> Most of the QA focus is on what the code does and what functional requirements are taken care of in different parts of the code. It does not matter much if the code is beautifully written unless it also happens to meet all of the functional requirements. In the code walkthroughs I have attended we always looked for how the code implemented what was requested. Sometimes there would be recommendations for more elegant ways of coding, sometimes people would catch code errors, but the emphasis was on how the code achieved the expected results.

    I don't want to take anything away from benefits like improving the level and quality of coding in future applications, especially if you focus on making the code easier to maintain and on making sure the code is well documented as you point out in your article. You mention QC, but I doubt that any QC would in fact catch poor quality coding as a result of testing (unless code fixes turn out to be horrendously difficult to implement). Maybe you can revisit that in your article.
    Frits Bos, PMP
    frits_bos@hotmail.com

  3. #3
    Senior Member
    Join Date
    Sep 2003
    Posts
    114
    Post Thanks / Like
    Mentioned
    0 Post(s)
    Tagged
    0 Thread(s)
    Total Downloaded
    0

    Re: Code Reviews Benefits

    Frits,

    The article discusses the positive site effects of code reviews under the assumption that it is pretty obvious that functional issues will be detected.

    As for your statement about code quality, I am very sorry to see a QA persona saying that compliance to functional requirements is all that matter!

    Simple and clear code is not a "nice to have" feature for developers. It is at the heart of a good product. If the code is messy, when the customer will want a new feature it migth be impossible (or very hard) to add it. Coming from a development background, I see it everyday: developers strugling with existing code in order to safely add a small feature. Is that your definition of quality product?

    Quality in software should be interpreted broadly. Of course functional requirements are important. But if you want a product that lives and evoloves you must also think about quality of design and implementation. They could not be separated from the overall quality of the product.

    QA should not focus solely on testing and functionality. There is much more to software quality than that....

    Want to read more: http://www.QualityProgramming.org (and see especially the article http://www.qualityprogramming.org/Im...rification.htm for a detailed explanation of Code Reviews)

    Lidor
    Lidor Wyssocky
    http://www.QualityAspect.com

    Visit The Mindset - Lidor Wyssocky's blog on Optimizing Software Development
    http://blog.QualityAspect.com

  4. #4
    Moderator
    Join Date
    Sep 2001
    Location
    Boston, MA
    Posts
    4,348
    Post Thanks / Like
    Mentioned
    0 Post(s)
    Tagged
    0 Thread(s)
    Total Downloaded
    0

    Re: Code Reviews Benefits

    As for your statement about code quality, I am very sorry to see a QA persona saying that compliance to functional requirements is all that matter!
    <font size="2" face="Verdana, Arial, Helvetica">absolutely.. creating code that meets functional specs is not all that matters. You want to design a system that is extensible and maintainable. You can make poor design decisions or sloppy implementation details that will put you in a position that will be regrettable down the line. You don't have to have everything perfect up front, but you don't want to be in a situation where you are refactoring major components just to make trivial fixes or changes.
    Corey Goldberg
    Homepage: goldb.org
    Twitter: twitter.com/cgoldberg
    Google+: gplus.to/cgoldberg

  5. #5
    Senior Member
    Join Date
    Jan 2005
    Location
    Aurora, Ont., Canada
    Posts
    1,174
    Post Thanks / Like
    Mentioned
    0 Post(s)
    Tagged
    0 Thread(s)
    Total Downloaded
    0

    Re: Code Reviews Benefits

    Lidor,

    I understand that you are a little testy when a person has a slightly different slant on what you have written, but if you care to re-read what I wrote it said "It does not matter much if the code is beautifully written unless it also happens to meet all of the functional requirements." I believe that your quote lifted something out of context, perhaps?

    I did not disagree with the basic benefits that you mentioned about maintainability etc., and as far as that is concerned I have been in the code development business for close to 40 years. Much of that was doing upgrades to existing code, the exact target of your article. If you want a quote then how about "I don't want to take anything away from benefits like improving the level and quality of coding in future applications, especially if you focus on making the code easier to maintain and on making sure the code is well documented as you point out in your article." as an example?

    If you ask for feedback, please be objective and accept feedback in the spirit in which it was provided. I believe that all the talk about code structure etc. is fine and dandy (and useful, and so forth), but I speak from experience that it is vitally important that you review the code based on what you were asked to write code for. If that seems to be an affront, I suggest you explain the context of quality in the absence of meeting or exceeding customer expectations...
    Frits Bos, PMP
    frits_bos@hotmail.com

  6. #6
    Senior Member
    Join Date
    Sep 2003
    Posts
    114
    Post Thanks / Like
    Mentioned
    0 Post(s)
    Tagged
    0 Thread(s)
    Total Downloaded
    0

    Re: Code Reviews Benefits

    Drits,

    First of all, I am not testy. I just meant that after years of trying to convince developers that code should not only perform well but also be written well, it is somewhat sad hearing a different view from a QA specialist.

    As for misquoting, now you misqoute me: I should not explain "explain the context of quality in the absence of meeting or exceeding customer expectations". Of course you have to meet the requirements. However, many developers/organizations care only about that. In light of that I have to stress out the "side" benefits of code quality. Claiming that I said that clear code is better than code that meets the requirements could not be further than the truth....

    By the way, if I understand Corey_G's posting correctly, he also interpreted your text as I did....

    Having said that, I always like feedback on my writings... this does not mean I have to agree with it... [img]images/icons/wink.gif[/img]

    Lidor
    Lidor Wyssocky
    http://www.QualityAspect.com

    Visit The Mindset - Lidor Wyssocky's blog on Optimizing Software Development
    http://blog.QualityAspect.com

 

 

Posting Permissions

  • You may not post new threads
  • You may not post replies
  • You may not post attachments
  • You may not edit your posts
  •  
Search Engine Optimisation provided by DragonByte SEO v2.0.36 (Pro) - vBulletin Mods & Addons Copyright © 2016 DragonByte Technologies Ltd.
Resources saved on this page: MySQL 11.11%
vBulletin Optimisation provided by vB Optimise v2.6.4 (Pro) - vBulletin Mods & Addons Copyright © 2016 DragonByte Technologies Ltd.
User Alert System provided by Advanced User Tagging v3.2.8 (Pro) - vBulletin Mods & Addons Copyright © 2016 DragonByte Technologies Ltd.
vBNominate (Lite) - vBulletin Mods & Addons Copyright © 2016 DragonByte Technologies Ltd.
Feedback Buttons provided by Advanced Post Thanks / Like (Pro) - vBulletin Mods & Addons Copyright © 2016 DragonByte Technologies Ltd.
Username Changing provided by Username Change (Free) - vBulletin Mods & Addons Copyright © 2016 DragonByte Technologies Ltd.
BetaSoft Inc.
Digital Point modules: Sphinx-based search
All times are GMT -8. The time now is 03:33 AM.

Copyright BetaSoft Inc.